Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File licensing issues #26

Open
paddatrapper opened this issue Jul 3, 2017 · 5 comments
Open

File licensing issues #26

paddatrapper opened this issue Jul 3, 2017 · 5 comments

Comments

@paddatrapper
Copy link

paddatrapper commented Jul 3, 2017

Background: See PR #23, this comment.
The following files are licensed under a license that prevents us using the Linux headers with them:

@paddatrapper paddatrapper changed the title File Licensing Issues File licensing issues Jul 3, 2017
@mithro
Copy link
Member

mithro commented Jul 9, 2017

I think the rest seem correct.

@paddatrapper
Copy link
Author

The license header for read-serialno.h specifically says version 3+: https://github.com/timvideos/HDMI2USB-fx2-firmware/blob/master/hdmi2usb/read-serialno.h#L6

@mithro
Copy link
Member

mithro commented Jul 17, 2017

Fixed read-serialno.h

@mithro
Copy link
Member

mithro commented Jul 17, 2017

We should aim to replace the following files;

  • makestuff.h - LGPLv3+

    • This just contains some simple defines, very easy to replace.
  • debug.h - LGPLv3+

    • What in this file is currently used?
  • lstParse.py - LGPLv3+

    • Any idea where this is used? It seems to talk about TDO/TDI stuff which is all JTAG related things.
  • defs.h - LGPLv3+

    • All the defs in here should already be in fx2lib
    • These defs are silly;
// Defines to allow use of camelCase.
#define mainInit(x) main_init(x)
#define mainLoop(x) main_loop(x)
#define handleVendorCommand handle_vendorcommand
  • app.c - LGPLv3+
    • This file should be replaceable with stuff from the example firmware in fx2lib.

@paddatrapper
Copy link
Author

debug.h is currently used in softserial.h, as it has the functions for writing to serial

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants