Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu too tall for some screens #282

Open
mattstauffer opened this issue Mar 10, 2022 · 5 comments · May be fixed by #328
Open

Menu too tall for some screens #282

mattstauffer opened this issue Mar 10, 2022 · 5 comments · May be fixed by #328

Comments

@mattstauffer
Copy link
Member

image

Let's look into whether the tool we're using to generate these has multi page options?

@tonysm
Copy link
Contributor

tonysm commented Apr 22, 2022

@mattstauffer I've looked into the Laravel Console Menu package (source) and the underlying cli-menu package from php-school (source) and looks like there's no option for pagination/scrolling.

We could, technically, limit the number of items displayed in the menu and add an extra "Show More" option or "Next" that would re-render the menu with more options (then showing "Prev" and "Next" options on subsequent pages). Basically implementing pagination manually on top of this menu package.

I personally find this kind of menu a bit limiting (it makes testing more complicated and I'm not very fond of the looks of it), wouldn't reimplementing this in a regular "choices" menu be a better solution? We could even have interactive autocompletion, like:

Screen.Recording.2022-04-22.at.17.00.28.mp4

@chrisdicarlo
Copy link
Contributor

@mattstauffer I've looked into the Laravel Console Menu package (source) and the underlying cli-menu package from php-school (source) and looks like there's no option for pagination/scrolling.

We could, technically, limit the number of items displayed in the menu and add an extra "Show More" option or "Next" that would re-render the menu with more options (then showing "Prev" and "Next" options on subsequent pages). Basically implementing pagination manually on top of this menu package.

I personally find this kind of menu a bit limiting (it makes testing more complicated and I'm not very fond of the looks of it), wouldn't reimplementing this in a regular "choices" menu be a better solution? We could even have interactive autocompletion, like:

Screen.Recording.2022-04-22.at.17.00.28.mp4

I like that option!

@khanalpride
Copy link
Contributor

I have implemented this feature as below:

We can divide the service types and containers for each types into two display like this?

takeout-menu1

After "Database" is selected in the first menu? It shows like this:
takeout-menu2

The second menu could have back as well, which just shows the first menu (reset)? [Not implemented still]

Let me know if that's good?

@khanalpride
Copy link
Contributor

khanalpride commented Jan 12, 2023

I have implemented this feature as below:

We can divide the service types and containers for each types into two display like this?

takeout-menu1

After "Database" is selected in the first menu? It shows like this: takeout-menu2

The second menu could have back as well, which just shows the first menu (reset)? [Not implemented still]

Let me know if that's good?

Anyone came anywhere nearby this? @mattstauffer

@chrisdicarlo
Copy link
Contributor

I have implemented this feature as below:

We can divide the service types and containers for each types into two display like this?

takeout-menu1

After "Database" is selected in the first menu? It shows like this: takeout-menu2

The second menu could have back as well, which just shows the first menu (reset)? [Not implemented still]

Let me know if that's good?

I like this setup; keeps the list nice and compact.

@tonysm tonysm linked a pull request Dec 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants