Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling of n_max=NA could be improved #545

Open
jfsalzmann opened this issue Dec 12, 2024 · 0 comments
Open

Error handling of n_max=NA could be improved #545

jfsalzmann opened this issue Dec 12, 2024 · 0 comments

Comments

@jfsalzmann
Copy link

I recently had a hard time debugging that my code made a wrong vroom::vroom() call with an edge case bug on my side where I supplied n_max = NA.

Instead of some error/exception behaviour from vroom, there was an R error thrown from here, line 33

  if (n_max < 0 || is.infinite(n_max)) {
    n_max <- -1
  }

Error in if (condition) { : missing value where TRUE/FALSE needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant