Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider using fast_float for string => double conversions? #489

Open
kevinushey opened this issue Mar 2, 2023 · 1 comment
Open

consider using fast_float for string => double conversions? #489

kevinushey opened this issue Mar 2, 2023 · 1 comment
Labels
colspec 📁 feature a feature request or enhancement performance 🚀

Comments

@kevinushey
Copy link

From https://github.com/fastfloat/fast_float.

I'm speculating that "string" => "double" conversions are a relatively hot code path for readr, so it might be worth investigating whether this library could be used to optimize those conversions.
@jennybc
Copy link
Member

jennybc commented Mar 2, 2023

Anything like this, if it happened, would happen in vroom, so transferring

@jennybc jennybc transferred this issue from tidyverse/readr Mar 2, 2023
@hadley hadley added feature a feature request or enhancement colspec 📁 performance 🚀 labels Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
colspec 📁 feature a feature request or enhancement performance 🚀
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hadley @jennybc @kevinushey