Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add label in case of conflict #652

Merged
merged 2 commits into from
Jul 20, 2021

Conversation

Rustin170506
Copy link
Contributor

close #539

@ti-chi-bot ti-chi-bot added the dco-signoff: yes Indicates the PR's author has signed the dco. label Jul 20, 2021
@ti-chi-bot ti-chi-bot requested a review from Mini256 July 20, 2021 03:46
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 20, 2021
@github-actions
Copy link

github-actions bot commented Jul 20, 2021

🎊 PR Preview 659519b has been successfully built and deployed to https://ti-community-infra-tichi-preview-pr-652.surge.sh

🕐 Build time: 0.011s

🤖 By surge-preview

@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #652 (659519b) into master (96402c4) will decrease coverage by 0.09%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #652      +/-   ##
==========================================
- Coverage   80.35%   80.25%   -0.10%     
==========================================
  Files          17       17              
  Lines        2341     2345       +4     
==========================================
+ Hits         1881     1882       +1     
- Misses        304      306       +2     
- Partials      156      157       +1     
Impacted Files Coverage Δ
internal/pkg/externalplugins/label.go 71.42% <ø> (ø)
...l/pkg/externalplugins/cherrypicker/cherrypicker.go 61.55% <25.00%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96402c4...659519b. Read the comment docs.

@Rustin170506 Rustin170506 requested a review from Mini256 July 20, 2021 05:51
Signed-off-by: hi-rustin <[email protected]>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Mini256

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 20, 2021
@Mini256
Copy link
Member

Mini256 commented Jul 20, 2021

/merge

@hi-rustin, Thanks~

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 659519b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 20, 2021
@ti-chi-bot ti-chi-bot merged commit a168b92 into ti-community-infra:master Jul 20, 2021
Rustin170506 added a commit to Rustin170506/ti-community-prow that referenced this pull request Jul 21, 2021
Rustin170506 added a commit to Rustin170506/ti-community-prow that referenced this pull request Jul 21, 2021
ti-chi-bot pushed a commit that referenced this pull request Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When cherry-pick a conflicting PR, add a label to indicate this PR has conflicting
3 participants