Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in reproduction of run_DA-ADB.sh results #52

Open
EdwardBurgin opened this issue Jan 3, 2024 · 3 comments
Open

Error in reproduction of run_DA-ADB.sh results #52

EdwardBurgin opened this issue Jan 3, 2024 · 3 comments

Comments

@EdwardBurgin
Copy link

EdwardBurgin commented Jan 3, 2024

Is the example found in open_intent_detection/examples/run_DA-ADB.sh meant to reproduce the published results? Running this and comparing to ADB gives significantly worse results. I took a look to see why this is briefly but didn't find an obvious answer.

The average of ADB across the experiments gave 84% and DA-ADB gave 47%

Example of ADB results from which averages of Acc where calculated
DA-ADB_RES

The only change was the location of the bert model in hyper-parameters which was the same for both methods:
'bert_model': "bert-base-uncased",
Instead of: 'bert_model': "/home/sharing/disk1/pretrained_embedding/bert/uncased_L-12_H-768_A-12/",

Thanks for your help!

@thuiar thuiar deleted a comment from mrFocusXin Jan 9, 2024
@JianhuaSu
Copy link

The following is my reproduction of the results. The DA-ADB result is generally higher than that of ADB, so there is nothing wrong with our model. The only difference is that the position of the bert model I use in the hyperparameter is
“uncased_L-12_H-768_A-12”.
uTools_1704851857529
Could it be a bert version issue? You can give it a try uncased_L-12_H-768_A-12

@CodingPerson
Copy link

我发现问题了,您在run_DA-ADB.sh中少加了--save_model这个参数,导致没法存储模型了

@TzuchengChang
Copy link

Have u solved the above problems?
I've tried the bert-base-uncased model and the given BaiduNetdisk model (could it be uncased_L-12_H-768_A-12?), but it gave the wrong results in DA-ADB, too (about 50% Acc), while it gave correct result in ADB (80+ Acc).
How can I rebuild it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants