-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot render articulations #6
Comments
I managed to fix it. Here is a diff --- shamisen-original.ly 2024-12-09 13:02:42.007687846 +0000
+++ shamisen.ly 2024-12-09 13:01:43.158772674 +0000
@@ -152,35 +152,35 @@
#(append! default-script-alist
(list
- `("hajiki"
+ `(hajiki
. (
(stencil . ,ly:text-interface::print)
(text . ,hajiki-markup)
(quantize-position . #t)
(avoid-slur . around)
(direction . ,DOWN)))
- `("sukui"
+ `(sukui
. (
(stencil . ,ly:text-interface::print)
(text . ,sukui-markup)
(quantize-position . #t)
(avoid-slur . around)
(direction . ,DOWN)))
- `("uchi"
+ `(uchi
. (
(stencil . ,ly:text-interface::print)
(text . ,uchi-markup)
(quantize-position . #t)
(avoid-slur . around)
(direction . ,DOWN)))
- `("oshi"
+ `(oshi
. (
(stencil . ,ly:text-interface::print)
(text . ,oshi-markup)
(quantize-position . #t)
(avoid-slur . around)
(direction . ,DOWN)))
- `("keshi"
+ `(keshi
. (
(stencil . ,ly:text-interface::print)
(text . ,keshi-markup)
@@ -188,11 +188,11 @@
(avoid-slur . around)
(direction . ,DOWN)))))
-hajiki = #(make-articulation "hajiki")
-sukui = #(make-articulation "sukui")
-uchi = #(make-articulation "uchi")
-oshi = #(make-articulation "oshi")
-keshi = #(make-articulation "keshi")
+hajiki = #(make-articulation 'hajiki)
+sukui = #(make-articulation 'sukui)
+uchi = #(make-articulation 'uchi)
+oshi = #(make-articulation 'oshi)
+keshi = #(make-articulation 'keshi)
first = \markup { \teeny "Ⅰ" }
second = \markup { \teeny "Ⅱ" }
@@ -215,7 +215,7 @@
#(define (is-shamisen-articulation art)
(let* ((atype (ly:music-property art 'articulation-type))
(aname (ly:music-property art 'name))
- (atypes '("hajiki" "sukui" "uchi" "oshi" "keshi"))
+ (atypes '(hajiki sukui uchi oshi keshi))
(anames '(StringNumberEvent TextScriptEvent)))
(cond ((member atype atypes) #t)
((member aname anames) #t) |
Great work, thank you! I should have some time over the holiday to integrate this and check everything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
attempting to add
\sukui
to a score results inor with sakura sakura
The text was updated successfully, but these errors were encountered: