-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List & Modal #14
List & Modal #14
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/thenorthkun/fezco-ui/9PY7b6gtLMwBkxV1Lh1ZDXAoGRdi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciation: Good work, semantic html, understandable class names, small PR, you can make a few minor changes I suggested. :)
components/list/list.css
Outdated
.list{ | ||
list-style-type: none; | ||
width: 70%; | ||
max-width: 430px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rem ?
top: 0; | ||
left: 0; | ||
right: 0; | ||
background-color: rgba(65, 65, 65, 0.5); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
color variable?
max-width: 400px; | ||
border-radius: 4px; | ||
padding: 1.2rem; | ||
box-shadow: rgb(0 0 0 / 24%) 0px 10px 30px -14px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
color variable?
Added the following components / sub-components -
List
Modal
Preview: https://fezco-ui-git-list-modal-thenorthkun.vercel.app/components/list/list.html