Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List & Modal #14

Merged
merged 6 commits into from
Feb 27, 2022
Merged

List & Modal #14

merged 6 commits into from
Feb 27, 2022

Conversation

thenorthkun
Copy link
Owner

@thenorthkun thenorthkun commented Feb 25, 2022

Added the following components / sub-components -

List

  • Default List
  • Stacked List
  • Spaced List

Modal

  • Basic pop up modal

Preview: https://fezco-ui-git-list-modal-thenorthkun.vercel.app/components/list/list.html

@vercel
Copy link

vercel bot commented Feb 25, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/thenorthkun/fezco-ui/9PY7b6gtLMwBkxV1Lh1ZDXAoGRdi
✅ Preview: https://fezco-ui-git-list-modal-thenorthkun.vercel.app

This was linked to issues Feb 25, 2022
Closed
Copy link

@j24m j24m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciation: Good work, semantic html, understandable class names, small PR, you can make a few minor changes I suggested. :)

.list{
list-style-type: none;
width: 70%;
max-width: 430px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rem ?

top: 0;
left: 0;
right: 0;
background-color: rgba(65, 65, 65, 0.5);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

color variable?

max-width: 400px;
border-radius: 4px;
padding: 1.2rem;
box-shadow: rgb(0 0 0 / 24%) 0px 10px 30px -14px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

color variable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal Lists
2 participants