Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean code #1

Open
4 tasks
zawaze opened this issue Oct 11, 2024 · 0 comments
Open
4 tasks

Clean code #1

zawaze opened this issue Oct 11, 2024 · 0 comments
Assignees

Comments

@zawaze
Copy link
Contributor

zawaze commented Oct 11, 2024

  • Nettoyer le code afin qu'il respecte au moins PSR2
  • Changer l'emplacement du fichier de log dans var/log/
  • Changer l'emplacement des fichiers de configurations dans Config du module
  • Verifier tous les path actuel afin qu'il n'utilise pas le nom du module en dur ex:
    $synchronizationStatusFile = THELIA_MODULE_DIR . '/Shopimind/synchronization_status.yml';
@zawaze zawaze self-assigned this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant