Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Being shim agnostic #2

Open
Raynos opened this issue Jan 25, 2012 · 6 comments
Open

Being shim agnostic #2

Raynos opened this issue Jan 25, 2012 · 6 comments

Comments

@Raynos
Copy link

Raynos commented Jan 25, 2012

It would be nice if it could be documented what you need to emulate for full support here.

For example would it work in IE8+ if you threw the DOM-shim in? If not what is missing?

We really need a better way of documenting what DOM features need to be shimmed rather then saying "using this specific shim"

@termi
Copy link
Owner

termi commented Jan 25, 2012

I am thinking about it. I need to learn documentation markup

@Raynos
Copy link
Author

Raynos commented Jan 28, 2012

I just finished feature. This will allow you to define what features are needed. Something like

if (window.features && [
  "DOM.Element.getAttribute",
  "DOM.Document.createElement",
  ...
].every(function (n) { return window.features[n]; })) {
  /* run shim code as all the features necessary are present */
}

If you don't want to add it to the code you can add it in the documentation and reference feature.

@termi
Copy link
Owner

termi commented Jan 28, 2012

Great work!
I'll add Microdata items in features, after I'll get some rest.

@termi
Copy link
Owner

termi commented Jan 28, 2012

Note: for now, this lib incompatible with you shim, only because of require of DOMSettableList object ( or rather because of my implimentation of this interface ).

I am think about replacement native implementation for allow developer create instances of this class. Is this a bad idea?

@Raynos
Copy link
Author

Raynos commented Jan 28, 2012

If there is no good alternative then it's a good idea. I need to do my own research to tell whether there are alternatives.

@termi
Copy link
Owner

termi commented Jan 31, 2012

Add Wiki page fo shim algorithm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants