New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explorer Tests are manually defined in tools/test folder #1297

Open

vprajapati-tt opened this issue Nov 15, 2024 · 1 comment · May be fixed by #1333

Labels

bug explorer

Contributor

vprajapati-tt commented Nov 15, 2024

Refers to failure on https://github.com/tenstorrent/tt-mlir/actions/runs/11863916419/job/33066315869
Tests are manually defined, so if the MLIR spec is changed then the model parsing could fail and result in red PR.
In this case, the SystemDesc is piped into the open_llama_3b_single_layer.mlir and wasn't updated to the new spec.
Approaches:

Don't manually define tests, somehow generate these MLIR models to then be rendered using CI (building on top of check-ttmlir and then running CI on build artifacts)
Keep tests in tests directory so they raise red flags in general tests and hopefully get updated as part of the PR.

The text was updated successfully, but these errors were encountered:

vprajapati-tt added bug explorer labels

Contributor

odjuricicTT commented Nov 18, 2024

@vprajapati-tt Thanks for pointing this out.

For system desc specifically, i think we can just remove it from the tests as it is optional.

More generally, are the explorer mlir tests different that Filecheck mlir tests. Both need to be updated the same way if MLIR spec is changed?

vprajapati-tt linked a pull request

that will close this issue

Autogenerate TTNN Tests for Explorer CI to consume #1333

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment