-
Notifications
You must be signed in to change notification settings - Fork 609
Static Shape Mismatch Checking: Any examples? #260
Comments
Hi @huan ! Thanks for reaching out. This is an excellent question and one I'm happy to say we've been actively working on. Since we started (when All the best, |
Also, in regards to MNIST, we recently restructured tensorflow/swift-models to pull out datasets and be able to reuse them across models and examples. One of these datasets is MNIST, but the current implementation has some known problems. If you'd want to pull in your implementation of MNIST and integrate it with the models there, we'd be glad to have it. |
@saeta Thanks for letting me know we have been actively working on this feature and the email list. The static shape checking is the feature that most excited me, I'm looking forward to reading the open design review from @apaszke-g. |
@BradLarson I would love to contribute on the Swift models repository, and it seems that my MNIST module borrowed lots of the code from the swift-models, and also download the data files from that repository. (I get the code from another Colab notebook the day before yesterday). What are the known problems for the current implementation, is there any issue for them? |
@huan - One big problem is that the current MNIST implementation in the repository lacks shuffling for the batches. The CIFAR10 dataset example has this, for example. Another is that it currently relies on hardcoded paths, which will break if you take the dataset outside of that project and try to use it in something like Colab. Also, there isn't a consistent API in the image classification datasets we have so far, so it would be nice to align the CIFAR10 and MNIST datasets such that they could be closer in that regard. I don't know how much we want to develop here (vs. in a framework like SwiftAI), but maybe there could be a protocol that image classification datasets could comply to. |
@BradLarson Got it. I had created another issue at tensorflow/swift-models#206 and let's move there to continue discussing. |
Hi @huan, You may be interested in https://github.com/google-research/swift-tfp - it's a project for static shape checking for Swift for TensorFlow. It seems tensorflow/swift-models#206 has been closed, so I'll close this issue now as well. |
Hello,
I'm an ML GDE who is working with @snowkylin and contributing the Swift for Tensorflow chapter for our book Tensorflow 2.0 Handbook which plan to be published right after the TF2.0 released.
I'm very interested in the following design goals and I thought we have already supported them, for example, the shape mismatch checking in the compile time.
However, I did not find any more information or examples after I had a hard search via Google & Github. Is there any discussion for the static shape mismatch checking, or for better, any examples?
Thanks!
BTW: I had created an MNIST Swift Module at here for use this dataset with ease.
The text was updated successfully, but these errors were encountered: