Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roundtrip of Changes of Table with repetition & span generated as JSON ODF Changes is incorrect #309

Open
svanteschubert opened this issue Jul 7, 2024 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@svanteschubert
Copy link
Contributor

When the test document of #298 is transformed to JSON changes and afterwards these changes are applied to an empty ODT document, the table has changed, which is an error.

The original document looks like this:
2024-07-07 14_42_24-tableRowDeletionTest odt - LibreOffice Writer

the JSON generated from it is called tableRowDeletionTest.odt--initial_ops.json

The ODT when the ODF changes are applied to an empty ODT document is name tableRowDeletionTest.odt--OUT-new.odt and looks like this:
2024-07-07 14_42_07-tableRowDeletionTest odt--OUT-new odt - LibreOffice Writer

The JSON file, which is again generated from the above ODTis called:
tableRowDeletionTest.odt--new-reloaded_ops.json

The JSON files are being generated when building/testing ODFDOM via 'mvn install'

The new JSON files are being generated in:
odftoolkit/odfdom/target/test-classes/test-output/operations/
the references can be found in:
odftoolkit/odfdom/src/test/resources/test-reference/operations/

PS: Please note that there is currently also a derivation of the ODT files, likely due to the recent patch of Michael. I just pinged him to double check this. :-)

@svanteschubert svanteschubert added the help wanted Extra attention is needed label Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant