Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize decoding tree to save more memory #2

Open
tcsullivan opened this issue Dec 31, 2020 · 1 comment
Open

Optimize decoding tree to save more memory #2

tcsullivan opened this issue Dec 31, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@tcsullivan
Copy link
Owner

See here.

Most importantly, we need to allow for larger decoding trees. Secondly though (and maybe this should be a separate issue), the decoding tree could likely be refined/redesigned to either take up less memory or work more efficiently.
@tcsullivan tcsullivan added bug Something isn't working enhancement New feature or request labels Dec 31, 2020
@tcsullivan tcsullivan changed the title Decoding tree limited to 256 nodes Decoding tree fails if poorly balanced Dec 31, 2020
@tcsullivan
Copy link
Owner Author

Forgot that the input data gets left uncompressed if compression doesn't save space. The bug was simply in decoder::end returning a byte beyond what it should have for the uncompressed scenario. I'll commit the fix for the bug, but will still leave this issue up for the possibility of enhancing the decoder tree.

tcsullivan added a commit that referenced this issue Dec 31, 2020
@tcsullivan
Fixed decoder::end() for uncompressed scenario
2028b12 
See issue #2
@tcsullivan tcsullivan removed the bug Something isn't working label Dec 31, 2020
@tcsullivan tcsullivan changed the title Decoding tree fails if poorly balanced Optimize decoding tree to save more memory Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tcsullivan