Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fine tuning of color markings #5

Open
Marrrrtthias opened this issue Sep 13, 2022 · 3 comments
Open

fine tuning of color markings #5

Marrrrtthias opened this issue Sep 13, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@Marrrrtthias
Copy link

The color markings seem very arbitrary. When I open the app right now, pretty much every station in my area is green. Only one in my city is yellow and red is not even used for ANY station shown on the map even when zoomed out.

IMG_2965
IMG_2966

After looking at the code, this seems to be the intended behaviour:

if (minPrice + 0.04 >= price) {
  return StationPriceRange.cheap;
} else if (minPrice + 0.10 >= price) {
  return StationPriceRange.normal;
} else {
  return StationPriceRange.expensive;
}

I would suggest using a different logic for the categorisation. Instead of having a fixed width for each category, in my opinion it would be better to look at the range of prices that actually exist in the area and have an "intelligent" scale: For example if the prices go from min to max:

  • mark the stations in the bottom 10 % of that interval as green (price <= min + ((max-min)*.1))
  • mark stations in the top 50 % as red (price >= min + ((max-min)*.5))
  • and everything in between as yellow

That way the scale would actually show which stations are the cheapest instead of just showing everything marked as cheap if prices are close together.

@Fabi755
Copy link
Member

Fabi755 commented Sep 20, 2022

Thanks for your feedback and given solution! 💜

My first implementation was based on a similar logic. The main problem are the maximum prices of the stations. Most of the time highways-stations have a very expensive price compared to other stations. What will expand the min - max range on areas with highway near. This will cause that the minimum (10%) range gets bigger then. As result it is not as cheap as it looks.

That is the reason for the static solution. I have compared our current version with the Bertha app and was looking similar.

But now to your idea:
Have your tested the suggested solution, do have a better experience with that? I will try it out by myself the next days. And will give feedback here what is my outcome 😄


At this moment the markers look better on Kaiserslautern:

@Fabi755 Fabi755 added the enhancement New feature or request label Sep 20, 2022
@Marrrrtthias
Copy link
Author

I also noticed the highway stations. But to me it still seems better this way for the simple reason that less stations are marked as green. For me and probably most users the green stations are the most important and as such the colors are useless if nearly all stations are marked green as with the current implementation. The current color logic makes it very hard to see which stations are actually cheapest because so many stations are green.

Maybe it would already be enough to simply change the cutoff value and only show stations within 1 or 2 cents of the cheapest station as green. Instead of the current 4 cent cutoff.

Another alternative that I haven't tested and might even be overkill would to use the dynamic price range I am suggesting but marking any stations that are more than 10 cent above the median price as red by default and not including them in the price range calculation at all.

@Fabi755 Fabi755 transferred this issue from tankste/app Dec 10, 2023
@Fabi755
Copy link
Member

Fabi755 commented Dec 10, 2023

Moved to backend project, while the calculation of markers are done here now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants