Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack overflow inverting parent relation #2

Open
talex5 opened this issue Apr 28, 2015 · 0 comments
Open

Stack overflow inverting parent relation #2

talex5 opened this issue Apr 28, 2015 · 0 comments
Labels

Comments

@talex5
Copy link
Owner

talex5 commented Apr 28, 2015

If you use the history view (or sync) to move from a revision where A is a parent of B to one where B is a parent of A in one step then the display code will fail with a stack overflow.

This is because it tries to show the old A fading out, but the old A now has a child B, which has a child A, ...

We should either detect the loop and stop, or refuse to add new children to things that are fading out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant