Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tact should be installable with Node.js 23 #1217

Open
anton-trunov opened this issue Dec 19, 2024 · 1 comment
Open

Tact should be installable with Node.js 23 #1217

anton-trunov opened this issue Dec 19, 2024 · 1 comment
Labels
bug Something isn't working or isn't right
Milestone

Comments

@anton-trunov
Copy link
Member

$ yarn
yarn install v1.22.22
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
error [email protected]: The engine "node" is incompatible with this module. Expected version "^18.18.0  ^20.9.0  ^22.0.0". Got "23.1.0"
error Found incompatible module.

Reported by @Shvandre: he mentions it used to work until recently

@anton-trunov anton-trunov added the bug Something isn't working or isn't right label Dec 19, 2024
@anton-trunov anton-trunov added this to the v1.6.0 milestone Dec 19, 2024
@Shvandre
Copy link
Contributor

And also

in newer versions of Node.js our grammar.ts has to be updated with ['astOfSmth' ] accesses and not .astOfSmth()

Or it will cause an error like this

$ tact --config ./tact.config.json
/home/b4cksl4sh/tact/node_modules/ohm-js/dist/ohm.cjs:4484
      throw error;
      ^

Error: Found errors in the action dictionary of the 'astOfExpression' operation:
- 'EndOfIdentifiers_regular' is not a valid semantic action for 'Tact'
- 'EndOfIdentifiers_ignoreUnspecifiedFields' is not a valid semantic action for 'Tact'
    at Grammar._checkTopDownActionDict (/home/b4cksl4sh/tact/node_modules/ohm-js/dist/ohm.cjs:4477:21)
    at Operation.checkActionDict (/home/b4cksl4sh/tact/node_modules/ohm-js/dist/ohm.cjs:4282:13)
    at Semantics.addOperationOrAttribute (/home/b4cksl4sh/tact/node_modules/ohm-js/dist/ohm.cjs:3996:11)
    at proxy.addOperation (/home/b4cksl4sh/tact/node_modules/ohm-js/dist/ohm.cjs:4200:7)
    at Object.<anonymous> (/home/b4cksl4sh/tact/dist/grammar/grammar.js:779:11)
    at Module._compile (node:internal/modules/cjs/loader:1572:14)
    at Object..js (node:internal/modules/cjs/loader:1709:10)
    at Module.load (node:internal/modules/cjs/loader:1315:32)
    at Function._load (node:internal/modules/cjs/loader:1125:12)
    at TracingChannel.traceSync (node:diagnostics_channel:322:14) {
  problems: [
    "'EndOfIdentifiers_regular' is not a valid semantic action for 'Tact'",
    "'EndOfIdentifiers_ignoreUnspecifiedFields' is not a valid semantic action for 'Tact'"
  ]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working or isn't right
Projects
None yet
Development

No branches or pull requests

2 participants