Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unlock settings not applied correctly due to ID mismatches #101

Open
jensschuppe opened this issue Apr 23, 2020 · 1 comment
Open

Unlock settings not applied correctly due to ID mismatches #101

jensschuppe opened this issue Apr 23, 2020 · 1 comment
Labels
bug status:fixed The issue has been resolved (usually by committing/merging code).
Milestone
2.0

Comments

@jensschuppe
Copy link
Collaborator

jensschuppe commented Apr 23, 2020 •
edited
Loading

When validating contribution edits to check for whether altering a specific field's value is allowed according to the "Contribution unlock" settings in the donrec profile, the extension is trying to retrieve those settings for a CRM_Donrec_Logic_ReceiptItem ID when it has to be a CRM_Donrec_Logic_Receipt ID.

This may lead to

  • using potentially different settings if a ReceiptItem ID happens to be there for the requested Receipt
  • uncaught exceptions when no Receipt with the ReceipItem ID exists
@jensschuppe jensschuppe added this to the 2.1 milestone Apr 23, 2020
@jensschuppe jensschuppe self-assigned this Apr 23, 2020
@jensschuppe jensschuppe modified the milestones: 2.1, 2.0 Apr 23, 2020
jensschuppe added a commit that referenced this issue Apr 23, 2020
@jensschuppe
[#101] Use receipt instead of receipt item ID for retrieving profile …
e0b8d14 
…settings when validating contributions
jensschuppe added a commit that referenced this issue Apr 23, 2020
@jensschuppe
Merge branch 'issue/101' into release/2.0.x
f960926 
[#101] Unlock settings not applied correctly due to ID mismatches
jensschuppe added a commit that referenced this issue Apr 23, 2020
@jensschuppe
Merge branch 'issue/101'
34c65c1 
[#101] Unlock settings not applied correctly due to ID mismatches
@jensschuppe jensschuppe mentioned this issue Aug 19, 2020
Closed
@bjendres
Copy link
Member

Released with 2.0

@bjendres bjendres reopened this Nov 27, 2020
@bjendres bjendres modified the milestones: 2.0, 2.1 Nov 27, 2020
@jensschuppe jensschuppe added the status:fixed The issue has been resolved (usually by committing/merging code). label Mar 25, 2021
@jensschuppe jensschuppe removed their assignment Mar 25, 2021
@bjendres bjendres mentioned this issue Apr 23, 2021
Closed
@bjendres bjendres modified the milestones: 2.1, 2.0 Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug status:fixed The issue has been resolved (usually by committing/merging code).
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@bjendres @jensschuppe