Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate retry to add extra validation for other destinations than EVM chains #393

Open
LyonSsS opened this issue Dec 10, 2024 · 3 comments

Comments

@LyonSsS
Copy link

LyonSsS commented Dec 10, 2024

Context: Currently on EVM automate retry checks at a certain interval, with indexer, if a deposit is executed and if it is not it emits the execute proposal command on destination. This interval may some time be < the actual time it takes to execute the initial deposit.
Some times it may execute 2 times on destinations, which, it is not a problem for EVM chains as solidity contracts know to handle this, but it may be on chains like BTC or substrate.
This situation already occurred during testing:

  1. first exec https://holesky.etherscan.io/tx/0x781d3a23d1f2647f24d5e10aefb2888c34fd9026d7b8630cdba461b8a2ba55db
  2. https://holesky.etherscan.io/tx/0xb60090e448ab65e284e10dda99faa84710b0add2370e033396d9e279703daf5b
@MakMuftic
Copy link
Contributor

I believe there is also on-chain check on Substrate, but @freddyli7 @mpetrun5 to confirm this 🙏

@freddyli7
Copy link
Contributor

I believe there is also on-chain check on Substrate, but @freddyli7 @mpetrun5 to confirm this 🙏

On substrate side, the executed proposal will be marked by the UsedNonces storage, so it should be functioning the same way as Solidity contract

@LyonSsS
Copy link
Author

LyonSsS commented Dec 16, 2024

Then this is perfect for the current mainnet set-up.
Only if we extend with BTC network we need to close this ticket with a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants