Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language switch improvement #4248

Closed
5 tasks done
alizedebray opened this issue Dec 13, 2024 · 0 comments · Fixed by #4260
Closed
5 tasks done

Language switch improvement #4248

alizedebray opened this issue Dec 13, 2024 · 0 comments · Fixed by #4260
Assignees
@leagrdv
Labels
📦 components Related to the @swisspost/design-system-components package
Milestone
PPNL Support

Comments

@alizedebray
Copy link
Contributor

alizedebray commented Dec 13, 2024 •
edited by leagrdv
Loading

  • Add hover state to language options on mobile
  • Add hover state to language options on desktop
  • Add focus state to language options on desktop
  • Make sure keyboard navigation behaves as expected on desktop (use the Menu Button as a reference)
  • Flatten the header docs

The look and feel of the trigger button on desktop has been updated in this PR: #4243
@alizedebray alizedebray added the 📦 components Related to the @swisspost/design-system-components package label Dec 13, 2024
@alizedebray alizedebray added this to the PPNL Components milestone Dec 13, 2024
@alizedebray alizedebray moved this from 👀 Triage to 💻 Ready for development in Design System Production Board Dec 13, 2024
@leagrdv leagrdv self-assigned this Dec 13, 2024
@leagrdv leagrdv linked a pull request Dec 13, 2024 that will close this issue
fix(components): update style of language switch and fix keyboard nav #4260
Merged
@leagrdv leagrdv moved this from 💻 Ready for development to 🤬 Dev in Code Review in Design System Production Board Dec 16, 2024
@github-project-automation github-project-automation bot moved this from 🤬 Dev in Code Review to 🚀 Done in Design System Production Board Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leagrdv leagrdv

Labels
📦 components Related to the @swisspost/design-system-components package
Projects
Design System Production Board
Status: 🚀 Done
Milestone
PPNL Support
Development

Successfully merging a pull request may close this issue.

fix(components): update style of language switch and fix keyboard nav swisspost/design-system
3 participants
@gfellerph @alizedebray @leagrdv