-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown editor improvements #164
Comments
Sorry, accidentally hit Ctrl+Enter haha.
|
@trustedtomato Thanks for checking out Sveltia CMS! Will have a look at these issues later today. |
The indent and focus issues are now solved in v0.34.5. I’ll work on the floating link editor later. |
Another item, just dumping it here:
Steps to reproduce the Ctrl+Z issue:
Interestingly, if I then type something, and then try Ctrl+Z, then it starts to work - until a certain point, seems like the history length is limited. On the same note - what do you think, would it make sense to just use a stripped down version of https://playground.lexical.dev/ ? When you implement custom widgets, I might want to experiment with that, it's such a snappy markdown editor, and includes everything one might ever need (YouTube videos, tables, images). |
Not sure why the undo/redo stack is having some problems. Will check. Lexical Playground is built with React, so it cannot be reused in Sveltia CMS, which is written in Svelte. For now, I’m just trying to rebuild the Markdown editor in Netlify/Decap CMS. We could have more built-in features in the future. 🙂 |
I mean, it can, it's just not pretty:D I have had the pleasure of implementing React components in Svelte. The React ecosystem is just too good to miss out on sometimes. But yeah, it's not pretty, and the playground website is 400 kB, so it'd be quite an overhead to the CMS. But I think having it as a custom widget later would make sense, since it's so feature rich and snappy. Though I can also see that with your speed, this Svelte based markdown editor will also quickly catch up on the most important features :) So let's see in what state the markdown editor will be when custom widgets are ready. And good job on the effort and huge thanks for the quick replies, I'm definitely feeling a lot more confident about migrating a client project to Sveltia in the summer. (Even if you don't support such a decision at this early stage haha.) |
I’m still struggling with the undo issue. Not only undo/redo, but keyboard shortcuts like Ctrl+B for bold text are completely broken in Firefox. Hopefully I can fix this soon. Implementing Lexical is soooo difficult. |
I haven't worked with Lexical before. It seems nice, but it also seems like only the React integration is taken very seriously. I have worked with TipTap + Svelte before though with a similar feature set compared to what's required here, and that was a very pleasant experience, it really seems to treat vanilla JS as its first class citizen. They even have a Svelte example on their "default text editor" example:) If you look at the example code they have for Svelte, that's pretty much all we need, with the need to
And probably that's it:) Probably I'm missing some points, but those are the biggest complexities at first glance. Disclaimer, I don't have any connection to the TipTap guys whatsover, I just used their library before, and I it seems to be a good fit here, without the need for such solutions as that setTimeout 500 :D |
The keyboard shortcut issues solved with v0.34.8 💦 |
Hello,
First of all, thank you for the great library!:) I've been in the exact situation as you, namely that a lot of my clients are using Decap CMS, but I experienced a bunch of performance and Slate related issues with it, and this project fixes all issues I had!:)
However, there are several issues related to the markdown editor. If you don't have time to fix them, then can also take a shot at them in a few weeks, looks appealing that there is no tech debt in this repo yet, and I'm also developing everything I can in Svelte:)
The text was updated successfully, but these errors were encountered: