You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Small nitpick here, the Swift API Guidelines state that getters should not begin with get, as it's implicit in the fact that the method returns something.
@harlanhaskins Thank you so much for the issue! My rationale being having get in the getter names was that the original Objective-C Runtime methods such as class_getName, class_getProperty, objc_getClassList etc. all have get too. I was trying to follow the name structure of these runtime methods.
However, I agree that removing the get gives a slightly cleaner API and so I will change to that in the next release. Do let me know if you have any other suggestions or complaints about Lumos. Thank you :)
Small nitpick here, the Swift API Guidelines state that getters should not begin with
get
, as it's implicit in the fact that the method returns something.Maybe change things like:
to
The text was updated successfully, but these errors were encountered: