Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sul-requests/prod] NoMethodError: undefined method `callnumber' for nil:NilClass #1903

Open
cbeer opened this issue Oct 9, 2023 — with Honeybadger · 2 comments · Fixed by #1904
Open

[sul-requests/prod] NoMethodError: undefined method `callnumber' for nil:NilClass #1903

cbeer opened this issue Oct 9, 2023 — with Honeybadger · 2 comments · Fixed by #1904
Assignees
@jcoyne

Comments

@cbeer Honeybadger
Copy link
Member

cbeer commented Oct 9, 2023

Backtrace

line 9 of [PROJECT_ROOT]/app/views/application/_item_selector.html.erb: block in _app_views_application__item_selector_html_erb__2102414554257885310_46680
line 2 of [PROJECT_ROOT]/app/views/application/_item_selector.html.erb: _app_views_application__item_selector_html_erb__2102414554257885310_46680
line 6 of [PROJECT_ROOT]/app/views/requests/_form.html.erb: block in _app_views_requests__form_html_erb___2803922545306347340_46600

View full backtrace and more info at honeybadger.io
@jcoyne jcoyne self-assigned this Oct 9, 2023
@jcoyne
Copy link
Contributor

jcoyne commented Oct 9, 2023

This occurs because their are no holdings found in the specified location:

hr = HoldRecall.new(origin: 'BUSINESS', item_id: '14261607', origin_location: 'BUS-CRES', barcode: '20503757316')
hr.all_holdings.send(:items_in_location)
 => []

I think this is because the folio_location_code is nil

hr.library_location.folio_location_code
=> nil

jcoyne added a commit that referenced this issue Oct 9, 2023
@jcoyne
If the passed in origin isn't a Symphony location, then treat it as a…
1c4424a 
… Folio location

Fixes #1903
@jcoyne jcoyne mentioned this issue Oct 9, 2023
Merged
jcoyne added a commit that referenced this issue Oct 9, 2023
@jcoyne
If the passed in origin isn't a Symphony location, then treat it as a…
262b76a 
… Folio location

Fixes #1903
@cbeer
Copy link
Member Author

cbeer commented Oct 19, 2023

This is still happening.

@cbeer cbeer reopened this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcoyne jcoyne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

If the passed in origin isn't a Symphony location, then treat it as a… sul-dlss/sul-requests
2 participants
@jcoyne @cbeer