Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

httpclient dependency does not appear to be maintained #1501

Open
jcoyne opened this issue Aug 12, 2024 · 1 comment
Open

httpclient dependency does not appear to be maintained #1501

jcoyne opened this issue Aug 12, 2024 · 1 comment

Comments

@jcoyne
Copy link
Contributor

jcoyne commented Aug 12, 2024

https://rubygems.org/gems/httpclient

@dnoneill dnoneill assigned dnoneill and unassigned dnoneill Oct 28, 2024
@dnoneill
Copy link
Contributor

It looks like we won't be able to migrate until traject migrates. I updated httpclient to http (using the gem we are already using) and I am getting an error from the gem ```.rbenv/versions/3.3.0/lib/ruby/gems/3.3.0/gems/traject-3.8.2/lib/traject/solr_json_writer.rb:366:in commit': undefined method receive_timeout' for an instance of HTTP::Client (NoMethodError)

original_timeout = @http_client.receive_timeout```

I have linked to a draft PR in case we update traject
https://github.com/sul-dlss/searchworks_traject_indexer/pull/1532/files

@dnoneill dnoneill removed their assignment Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants