From c395d991671993e204905c8a75e7d34293b8dab4 Mon Sep 17 00:00:00 2001
From: Justin Coyne <jcoyne@justincoyne.com>
Date: Fri, 8 Mar 2024 15:04:11 -0600
Subject: [PATCH] Remove aria-expanded from location accordion

aria-expanded is supposed to go on the focusable interactive control that displays the collapsable section, not the collapsable section itself.

See https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-expanded
---
 app/views/catalog/_accordion_section_library.html.erb          | 2 +-
 spec/views/catalog/_accordion_section_library.html.erb_spec.rb | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/views/catalog/_accordion_section_library.html.erb b/app/views/catalog/_accordion_section_library.html.erb
index 193cb87e1..6158ef7d0 100644
--- a/app/views/catalog/_accordion_section_library.html.erb
+++ b/app/views/catalog/_accordion_section_library.html.erb
@@ -13,7 +13,7 @@
         <%= snippet %>
       </span>
     </div>
-    <div class="details <%= id %>-location" aria-expanded="false" data-controller="live-lookup" data-live-lookup-url-value="<%= availability_index_path %>">
+    <div class="details <%= id %>-location" data-controller="live-lookup" data-live-lookup-url-value="<%= availability_index_path %>">
       <% if document.holdings.present? %>
         <% document.holdings.libraries.select(&:present?).each do |library| %>
           <%= render SearchResult::LocationComponent.new(library:, document:) %>
diff --git a/spec/views/catalog/_accordion_section_library.html.erb_spec.rb b/spec/views/catalog/_accordion_section_library.html.erb_spec.rb
index 5afcac69c..92d9ec2cd 100644
--- a/spec/views/catalog/_accordion_section_library.html.erb_spec.rb
+++ b/spec/views/catalog/_accordion_section_library.html.erb_spec.rb
@@ -23,7 +23,7 @@
       expect(rendered).to have_css('.accordion-section.location')
       expect(rendered).to have_css('.accordion-section.location button.header[aria-expanded="false"]', text: "Check availability")
       expect(rendered).to have_css('.accordion-section.location span.snippet', text: "Green Library")
-      expect(rendered).to have_css('.accordion-section .details[aria-expanded="false"]')
+      expect(rendered).to have_css('.accordion-section .details')
       expect(rendered).to have_css('.accordion-section .details tbody tr', count: 2)
       expect(rendered).to have_css('.accordion-section .details tbody tr th', text: /Stacks/)
       expect(rendered).to have_css('.accordion-section .details tbody tr td', text: /ABC 123/)