-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call to undefined method Roots\Acorn\Bootloader::getApplication() #1
Comments
@braco: For reproducing the error you submitted, I just cloned this theme repository without any changes and put into a WordPress/Bedrock development environment, and everything works fine out of the box. Are you just using this sample theme without any changes?
|
Hey @strarsis, thanks for the reply. This is the base theme with no modifications. Notably, the core Sage theme doesn't throw any errors.
|
@braco: You can check out the original files: Is your PHP CLI also version |
I wiped everything and did a checkout again, same problem. PHP CLI is the same version yes. Just re-verified that Sage 10.5.1 works, looks like you're a few versions behind? Any other ideas? |
Yes, this version is slightly older, still supporting PHP 7.x. |
Just out of curiosity: I haven't used PHP in a decade, and this is my first Sage project – why does it seem like these Sage extension projects have to copy the entire repo instead of providing a plugin? |
@braco: In this case this is not a plugin, but a modified Sage theme. It also requires an So you could just create a new Sage 10 theme and then apply the FSE-specific modifications on top of it. |
got it, and it's hard to modularly extend Sage (sage plugins?) in a way that's durable between updates? I'm just starting to wade in to the development and surprised by the lack of full examples in the ecosystem. |
@braco: I updated the underlying Sage 10 to latest version, also an updated |
@braco: When you got time to test this, let me know whether your issue still persists. |
Hi! @strarsis Is there a chance to use sage 10 hybrid with FSE? I'm trying to get the effect that FSE templates are overwritten by blade template. |
I think I figured out if we can use instead: to this:
on acorn FiltersTemplates.php |
@r-chrzan: When this preserves the existing FSE-compatibility, I would replace that line in the |
@strarsis I'm currently setting up an e-commerce + FSE project, so it's a good time to test it out. I'll let you know if all the templates work properly. And if I run into problems, I'll share it here. |
@r-chrzan: You may find this example interesting for WooCommerce Gutenberg blocks: |
@strarsis thanks! very helpful! |
Hey, just tried your theme out, it errors for me on this line:
https://github.com/WordPress/WordPress/blob/master/wp-includes/class-wp-hook.php#L308
and
/app/wordpress/vendor/roots/acorn/src/Roots/helpers.php:57
The text was updated successfully, but these errors were encountered: