Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unformatted devices cannot be resized #787

Open
vojtechtrefny opened this issue Jul 15, 2019 · 4 comments
Open

Unformatted devices cannot be resized #787

vojtechtrefny opened this issue Jul 15, 2019 · 4 comments
Assignees

Comments

@vojtechtrefny
Copy link
Member

Device is not resizable if the format is not resizable and the "default" DeviceFormat is not resizable.

@vojtechtrefny vojtechtrefny self-assigned this Jul 15, 2019
@vpodzime
Copy link
Contributor

Isn't this on purpose to prevent issues with resizing devices with unknown formats?

@vojtechtrefny
Copy link
Member Author

Yes, this would require bigger changes in the DeviceFormat, probably creating some new "UnknownFormat" class for devices with some format (recognized by blkid) but without support in blivet, and maybe even some special "NoFormat" for devices without a format (or format not recognized by blkid, but I think we can safely say device is not formatted if blkid tells us there is nothing on it).

@dwlehman
Copy link
Contributor

There is also this to differentiate between "blkid reported nothing" and "blivet chose DeviceFormat":

https://github.com/storaged-project/blivet/blob/3.1-devel/blivet/formats/__init__.py#L105

@dwlehman
Copy link
Contributor

An unformatted device could also be removed/replaced as a workaround. This all to avoid the case of an angry careless person whose device containing some rare formatting was resized, causing data loss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants