Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI job #21

Merged
merged 8 commits into from
Nov 9, 2024
Merged

Fix CI job #21

merged 8 commits into from
Nov 9, 2024

Conversation

theogf
Copy link
Contributor

@theogf theogf commented Oct 28, 2024

Attempt to fix CI after #20

@thomvet
Copy link
Contributor

thomvet commented Oct 28, 2024

Tests are calling Makie and opening a figure; this only works when a monitor is present or when setting headless.
An example is shown here: https://github.com/MakieOrg/Makie.jl/blob/e5ace3b80659472b6b9ca9111d157c07a771ed87/.github/workflows/Docs.yml#L47

See also here: https://docs.makie.org/dev/explanations/headless

@theogf
Copy link
Contributor Author

theogf commented Oct 28, 2024

Tests are calling Makie and opening a figure; this only works when a monitor is present or when setting headless. An example is shown here: https://github.com/MakieOrg/Makie.jl/blob/e5ace3b80659472b6b9ca9111d157c07a771ed87/.github/workflows/Docs.yml#L47

See also here: https://docs.makie.org/dev/explanations/headless

That makes sense, it seems they only test on Linux though. We could just disable MacOS and Windows tests here?

@theogf theogf changed the title Use env instead Fix CI job Oct 28, 2024
@thomvet
Copy link
Contributor

thomvet commented Oct 28, 2024

Awesome job fixing this!

@theogf
Copy link
Contributor Author

theogf commented Oct 28, 2024

@stelmo This should be ready to be merged! Do you think you could tag a new release at the same time?

@stelmo
Copy link
Owner

stelmo commented Nov 9, 2024

Hi there! Really sorry about the delay, I was writing a grant :) Will merge and release asap

@stelmo stelmo merged commit 2484dc1 into stelmo:master Nov 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants