Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SEP-6 flow #363

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Fix SEP-6 flow #363

merged 1 commit into from
Sep 5, 2024

Conversation

quietbits
Copy link
Contributor

  • Use the correct delivery method
  • Show country code even if there is one item, but make it optional (some cases might still require a country code to be sumitted)
  • Small cleanup for clarity

@stellar-jenkins
Copy link

Preview is available here:
http://stellar-demo-wallet-client-pr363.previews.kube001.services.stellar-ops.com/

philipliu
philipliu approved these changes Sep 5, 2024
View reviewed changes
Copy link

@philipliu philipliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quietbits quietbits merged commit f217387 into master Sep 5, 2024
2 checks passed
@quietbits quietbits deleted the sep6-fix branch September 5, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipliu philipliu philipliu approved these changes

@JakeUrban JakeUrban Awaiting requested review from JakeUrban

@Ifropc Ifropc Awaiting requested review from Ifropc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quietbits @stellar-jenkins @philipliu