Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont build client docker image with hard coded values for CLIENT_DOMAIN and WALLET_BACKEND_SERVER #260

Open
stfung77 opened this issue Dec 20, 2021 · 0 comments
Assignees

Comments

@stfung77
Copy link
Contributor

stfung77 commented Dec 20, 2021

What problem does your feature solve?

@jacekn suggest looking into another way to pass these values to the client in order to be able to reuse the built docker images. Currently, REACT_APP_CLIENT_DOMAIN and REACT_APP_WALLET_BACKEND_SERVER and passed as arguments during the docker build step so the client code gets compiled with the proper values. This is required because the compiled files are just static files being served by nginx.

Note: this method is also how the anchor test is currently building images

What would you like to see?

@jacekn suggests trying a env-config.js file similar to whats being done here:
https://github.com/stellar/kube/blob/master/kube001-dev/namespaces/account-viewer-dev/account-viewer-v2-preview-03.yaml

@stfung77 stfung77 self-assigned this Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant