From 2e809acbcb0af1b0e257272e4e93ea9230b45d4b Mon Sep 17 00:00:00 2001
From: Shawn Reuland <shawn@stellar.org>
Date: Thu, 18 Apr 2024 13:43:36 -0700
Subject: [PATCH] #82: added readiness probe usage of new rpc health info and
 replicas=2 for zero downtime during upgrade

---
 .../soroban-rpc/templates/soroban-rpc-sts.yaml   | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/charts/soroban-rpc/templates/soroban-rpc-sts.yaml b/charts/soroban-rpc/templates/soroban-rpc-sts.yaml
index d92f1f1..a56f7f1 100644
--- a/charts/soroban-rpc/templates/soroban-rpc-sts.yaml
+++ b/charts/soroban-rpc/templates/soroban-rpc-sts.yaml
@@ -12,9 +12,13 @@ metadata:
     release: {{ .Release.Name }}
     heritage: {{ .Release.Service }}
 spec:
-  # Currently Soroban RPC doesn't support HA deployments.
-  # For that reason we hardcode replicas value at 1
-  replicas: 1
+  # Currently Soroban RPC doesn't support HA deployments over a single shared data store
+  # but, each replica pod in a statefulset will have it's own data store on it's PVC.
+  # This statefulset creates two replicas which will be monitored by the readiness probe. 
+  # Having two replicas also ensures zero downtime during upgrades as at least one replica is 
+  # gauranteed to be running while the other one is upgraded and catching backup to network 
+  # after restart
+  replicas: 2
   serviceName: {{ template "common.fullname" . }}
   selector:
     matchLabels:
@@ -73,7 +77,11 @@ spec:
                     "jsonrpc": "2.0",
                     "id": 10235,
                     "method": "getHealth"
-                  }' | grep "healthy"
+                  }' | jq -es 'if (. | length) == 0 then null else .[0] end | .result | .status == "healthy" and (.latestLedger - .oldestLedger >= (.ledgerRetentionWindow - 10))' > /dev/null;
+          failureThreshold: 2
+          periodSeconds: 10
+          successThreshold: 2
+          timeoutSeconds: 5         
         {{- if (.Values.sorobanRpc).resources}}
         resources:
 {{ toYaml .Values.sorobanRpc.resources | indent 10 }}