Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Syscall tweaks #1235

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Fix: Syscall tweaks #1235

merged 2 commits into from
Apr 25, 2024

Conversation

stoobie
Copy link
Collaborator

@stoobie stoobie commented Apr 25, 2024

Description of the Changes

Various stylistic edits to System calls topic.

PR Preview URL

System calls

Check List

  • Changes have been done against main branch, and PR does not conflict
  • PR title follows the convention: <docs/feat/fix/chore>(optional scope): <description>, e.g: fix: minor typos in code

This change is Reviewable

  Syntax -> Function signature
  Arguments -> Parameters
Removed italics from parameter names
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1235/documentation/ .

ArniStarkware
ArniStarkware previously approved these changes Apr 25, 2024
Copy link
Collaborator

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @odednaor)

@stoobie
Copy link
Collaborator Author

stoobie commented Apr 25, 2024

@ArniStarkware Please take another look. I realized that removing the italics was incorrect.

Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1235/documentation/ .

Copy link
Collaborator

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @odednaor)

@stoobie stoobie merged commit 78e19de into main Apr 25, 2024
4 checks passed
@stoobie stoobie deleted the steve/syscall_tweaks branch April 25, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants