Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Explain deployer_address #1234

Merged
merged 3 commits into from
Apr 30, 2024
Merged

fix: Explain deployer_address #1234

merged 3 commits into from
Apr 30, 2024

Conversation

stoobie
Copy link
Collaborator

@stoobie stoobie commented Apr 25, 2024

Description of the Changes

Clarify deployer_address, including deploy_from_zero.

PR Preview URL

Contract address
deploy

Check List

  • Changes have been done against main branch, and PR does not conflict
  • PR title follows the convention: <docs/feat/fix/chore>(optional scope): <description>, e.g: fix: minor typos in code

This change is Reviewable

@stoobie stoobie changed the title Explain deployer_address fix: Explain deployer_address Apr 25, 2024
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1234/documentation/ .

1 similar comment
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1234/documentation/ .

@stoobie stoobie force-pushed the steve/deploy_from_zero branch from bf3c8d7 to 60c9aab Compare April 25, 2024 12:00
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1234/documentation/ .

@stoobie stoobie force-pushed the steve/deploy_from_zero branch from 60c9aab to cc8ab0c Compare April 25, 2024 12:01
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1234/documentation/ .

@@ -177,7 +177,7 @@ Deploys a new instance of a previously declared class.
`_class_hash_`:: The class hash of the contract to be deployed.
`_contract_address_salt_`:: The salt, an arbitrary value provided by the sender, used in the computation of the xref:Smart_Contracts/contract-address.adoc[contract's address].
`_calldata_`:: The constructor's calldata. An array of felts.
`_deploy_from_zero_`:: A flag used for the contract address computation. If not set, the caller address will be used as the new contract's deployer address, otherwise 0 is used.
`_deploy_from_zero_`:: A flag that determines whether the deployer’s address affects the computation of the contract address. When not set, or when set to `FALSE`, the caller address is used as the new contract's deployer address. When set to `TRUE`, 0 is used.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then why is it always ZERO in the libs I looked at?
When are we using FALSE to use the caller address?

Copy link
Collaborator Author

@stoobie stoobie Apr 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See here

Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1234/documentation/ .

@stoobie stoobie merged commit 8dde8fe into main Apr 30, 2024
3 checks passed
@stoobie stoobie deleted the steve/deploy_from_zero branch April 30, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants