Adding ENEM Challenge Scenario & Maritaca AI model (Sabiá 7B) #3185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yifanmai
approved these changes
Dec 3, 2024
yifanmai
reviewed
Dec 5, 2024
Comment on lines
34
to
35
| def __init__(self): | ||
| super().__init__() |
There was a problem hiding this comment.
nit: delete empty constructor
|
|
||
| @pytest.mark.scenarios | ||
| def test_enem_challenge_scenario(): | ||
| enem_scenario = ENEMChallengeScenario(subset="test") |
There was a problem hiding this comment.
Test failing with:
src/helm/benchmark/scenarios/test_enem_challenge_scenario.py:10: error: Unexpected keyword argument "subset" for "ENEMChallengeScenario" [call-arg]
I think you just need to delete subset="test".
|
Thanks again! Note that I pushed a commit to your branch in order to fix the lint errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is intended to: