Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Transformer parameters optional and fallback to Calibrator.measured data to then gen transformer params #193

Open
jamienoss opened this issue Oct 16, 2024 · 1 comment

Comments

@jamienoss
Copy link
Member

We want Calibrators and Transformers to be trivially configurable and thus swappable. To do this, we need to make Transfomer.Config.parameters optional such that only some config fields are populated, e.g., polyfit degree, but not the actual polynomial coefficients.

Then, a calibrator would need measured_data (relates to #165) to call Transformer.fit to fit the measured data and generate the desired transformer parameters.

If both transformer optional params and calibrator optional measured data aren't present, obviously raise.

@jamienoss
Copy link
Member Author

@imaitland FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant