Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect kotlin webauthn configuration #16338

Open
franticticktick opened this issue Dec 23, 2024 · 0 comments · May be fixed by #16339
Open

Incorrect kotlin webauthn configuration #16338

franticticktick opened this issue Dec 23, 2024 · 0 comments · May be fixed by #16339
Labels
status: waiting-for-triage An issue we've not yet triaged type: bug A general bug

Comments

@franticticktick
Copy link
Contributor

WebAuthnDsl is implemented incorrectly, we need to change the implementation of the get() method according to the usual spring security template, as in other kotlin DSLs. Now, due to incorrect implementation, the default configuration will not work.

        @Bean
        open fun securityFilterChain(http: HttpSecurity): SecurityFilterChain {
            http{
                formLogin { }
                webAuthn { }
            }
            return http.build()
        }

In addition, the DSL is missing disableDefaultRegistrationPage.

@franticticktick franticticktick added status: waiting-for-triage An issue we've not yet triaged type: bug A general bug labels Dec 23, 2024
franticticktick added a commit to franticticktick/spring-security that referenced this issue Dec 23, 2024
@franticticktick franticticktick linked a pull request Dec 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged type: bug A general bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant