Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Settings.gradle's logic to handle different buildFile name could result in phantom subproject #16322

Open
guesshe opened this issue Dec 20, 2024 · 1 comment
Assignees
Labels
in: build An issue in the build status: waiting-for-feedback We need additional information before we can continue type: enhancement A general enhancement

Comments

@guesshe
Copy link

guesshe commented Dec 20, 2024

Expected Behavior
Regardless of the buildFile names, no phantom subprojects should be created.
 

If a subproject has a default buildFile name like build.grade, the build setup should NOT create a phantom subproject.
 
Current Behavior
If a new subproject is added in with structure like this spring-security-foo/spring-security-foo-bar, using a default buildFile name build.gradle under spring-security-foo-bar will result in the creation of a phantom subproject spring-security-foo.

No phantom subproject should be created due to the name change of the buildFile.

Context
Settings.gradle should be updated to give a consistent behavior for different buildFile names.

@guesshe guesshe added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Dec 20, 2024
@sjohnr
Copy link
Member

sjohnr commented Dec 22, 2024

@guesshe thanks for reaching out. Why do you need to create a subproject under spring-security? What exactly do you mean by “phantom subproject”? Can you please explain what issues you are having with the behavior of the settings file?

@sjohnr sjohnr self-assigned this Dec 22, 2024
@sjohnr sjohnr added status: waiting-for-feedback We need additional information before we can continue in: build An issue in the build and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: build An issue in the build status: waiting-for-feedback We need additional information before we can continue type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants