Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RepositoryRestMvcConfiguration should use defaultMessageConverters in extendHandlerExceptionResolvers #2431

Open
rajp33 opened this issue Nov 7, 2024 · 2 comments
Assignees
Labels
status: waiting-for-triage An issue we've not yet triaged

Comments

@rajp33
Copy link

rajp33 commented Nov 7, 2024

Right now the RepositoryRestMvcConfiguration uses the defaultMessageConverters property :

which is lazily loaded to all beans matching type HttpMessageConverter

this.defaultMessageConverters = beansOfType(context, HttpMessageConverter.class);

However there is also a bean defined:

that I think should be used instead. The property isn't necessary and circumvents application wide customization of the message converters present in the bean:

@rajp33
Copy link
Author

rajp33 commented Nov 7, 2024

Should be a very small PR, happy to submit if needed :)

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 7, 2024
@rajp33
Copy link
Author

rajp33 commented Nov 16, 2024

@odrotbohm let me know what you think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

No branches or pull requests

3 participants