-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support validation non PersistentEntity types #2252
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
An issue we've not yet triaged
label
Apr 13, 2023
any chance to get this reviewed before the next release on friday? |
Is there anything more I can do to get this ready to be merged? |
odrotbohm
pushed a commit
that referenced
this pull request
Mar 14, 2024
For entity types that use transient fields, the validation integration needs to treat those as normal bean types an must not reject the values right away. Fixes GH-2252.
odrotbohm
pushed a commit
that referenced
this pull request
Mar 14, 2024
For entity types that use transient fields, the validation integration needs to treat those as normal bean types an must not reject the values right away. Fixes GH-2252.
odrotbohm
changed the title
Support Validation for fields the type of which is not a PersistentEntity
Support validation non PersistentEntity types
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is required to perform validation on converted fields of JPA entities. Their types might not be managed types and as such no JPAPersistentEntity instances are created for them. Before these changes this would result in a NotReadablePropertyException every time there is a validation error in one of those fields.