Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use temporary file to pipe data to "spreedbox-license-keys" #5

Open
fancycode opened this issue Dec 12, 2016 · 1 comment
Open
Assignees

Comments

@fancycode
Copy link
Member

Creating a temporary file to pass data to the spreedbox-license-keys tool is unnecessary, this can be done directly using proc_open.

See http://stackoverflow.com/questions/2390604/how-to-pass-variables-as-stdin-into-command-line-from-php for an example.

This applies to

exec( 'cat ' . $tmpFilename . ' | spreedbox-license-keys --json request', $request) ;
and similar occurrences.

@PeterEdens
Copy link

PeterEdens commented Dec 13, 2016

Thanks, this is now being used for requesting the license when passing the json to spreedbox-license-keys. The install license code is using this this also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants