Postgres: Sets 'allowNull' on all non primary-key columns

[AndreKlang]

On this line:

sequelize-typescript-generator/src/dialects/DialectPostgres.ts

Line 306 in 6e2238d

allowNull: !!column.is_nullable && !column.is_primary,

column.is_nullable is always a string, YES or NO (ie. the datatype yes_or_no), so !!column.is_nullable will always be true.

This can (probably) be fixed by adding c.is_nullable = 'YES' as is_nullable, to the select. It may however conflict with the c.*, which in my opinion should be replaced by the actual columns used for clarity.

Tested on PostgreSQL 13.9 (Debian 13.9-1.pgdg110+1) on x86_64-pc-linux-gnu, compiled by gcc (Debian 10.2.1-6) 10.2.1 20210110, 64-bit

[viligante8]

Is there any update on this? We are trying to use this package as well and also running into this issue.