Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster MREW for DEB ? #62

Open
chmichael opened this issue Feb 20, 2021 · 8 comments
Open

Faster MREW for DEB ? #62

chmichael opened this issue Feb 20, 2021 · 8 comments

Comments

@chmichael
Copy link

Hello,
Take a look at the following articles! I think DEB can benefit from this. (it has 4 parts)
https://www.thedelphigeek.com/2020/11/readers-writer-lock-part-1-why.html

Thank you

@wxinix
Copy link
Contributor

wxinix commented Feb 20, 2021

The article is great but it doesn't say TLightweightMREW is a clear winner than TMREWSync which is used by DEB?

@spinettaro
Copy link
Owner

@chmichael I agree with @wxinix . From the article we cannot establish a clear winner as also reported in part 3. @chmichael do you have some numbers to highlight the fact the new TLightMREW is much better for this project?

@chmichael
Copy link
Author

chmichael commented Feb 21, 2021

@spinettaro @wxinix Did you read all the 4 parts ? (i posted only the 1st part, the other is on main page)
As @dkounal Part 3 and Part 4 has some numbers!

Do you we have a benchmark for DEB ?

@wxinix
Copy link
Contributor

wxinix commented Feb 21, 2021

I did read all parts. It is a great article by a respected Delphi guru. And thank you for referencing those articles.

Actually at one time DEB (for my private fork) did use the latest TLightweightMREW, which comes with Sydney 10.4 (in its release note it was noted for its slightly better performance)

But when I submitted my PR to the main DEB repo, I sticked to the old MREW, mainly for compatibility with older versions of Delphi, considering TLightweightMREW only works for the latest.

We can do a conditional compile of course. But the number in the article shows mixed benchmarking results —— it doesn’t seem to suggest a clear winner.

@dkounal
Copy link

dkounal commented Feb 21, 2021

I think that only windows can get a better speed but it is safe only with TLightweightMREWx and only in a number of scenarios

@chmichael
Copy link
Author

What ever you want guys but in my opinion it will be nice to have that option too! :)

@chmichael
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants