Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

videojs 6 deprication #88

Open
NoamPaz opened this issue May 9, 2018 · 8 comments
Open

videojs 6 deprication #88

NoamPaz opened this issue May 9, 2018 · 8 comments

Comments

@NoamPaz
Copy link

NoamPaz commented May 9, 2018

videojs version: 6.8.0

use the plugin as npm package (yarn add videojs-markers)

I get 2 warnings on run time:

  1. videojs.plugin() is deprecated; use videojs.registerPlugin() instead
  2. videojs.createEl() is deprecated; use videojs.dom.createEl() instead

It's still working, bug it's better to fix those warning

@NoamPaz
Copy link
Author

NoamPaz commented May 21, 2018

Seems like there is a pull request for this issue:
#86
Is it possible to review and approve it. Thanks.

@spchuang
Copy link
Owner

spchuang commented May 23, 2018 via email

@spchuang
Copy link
Owner

just accepted the pr

@NoamPaz
Copy link
Author

NoamPaz commented May 26, 2018

Thanks!!
Please bump the version and publish it to npm.

@jakubfrydrych
Copy link

Hi, thanks for fix !
Also please move the changes to npm.

@fealaer
Copy link

fealaer commented Aug 23, 2019

It seems like the main maintainer has left GitHub. :(
Due to this, I've released new version in the fork - npm.

@spchuang
Copy link
Owner

Hi, I'm happy to add other folks as collaborators if anyone is interested. I can also give access to update the npm package so people can continue with the same one without having to change to a new one

@Jeet-s
Copy link

Jeet-s commented Sep 25, 2023

@spchuang Is it fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants