-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
videojs 6 deprication #88
Comments
Seems like there is a pull request for this issue: |
Hi sorry for late reply. Haven’t had too much time to properly maintain the project. Yes I’ll take a look this week to approve the changes.
…Sent from my iPhone
On May 21, 2018, at 7:06 AM, Noam Paz ***@***.***> wrote:
Seems like there is a pull request for this issue:
#86
Is it possible to review and approve it. Thanks.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
just accepted the pr |
Thanks!! |
Hi, thanks for fix ! |
Hi, I'm happy to add other folks as collaborators if anyone is interested. I can also give access to update the npm package so people can continue with the same one without having to change to a new one |
@spchuang Is it fixed? |
videojs version: 6.8.0
use the plugin as npm package (yarn add videojs-markers)
I get 2 warnings on run time:
It's still working, bug it's better to fix those warning
The text was updated successfully, but these errors were encountered: