Should the MongoDB CXX driver source be removed from the docker image?

[ivanperez-keera]

The docker image installs mongo-cxx-driver-r3.6.7.

docker/space_robots/Dockerfile

Lines 72 to 73 in 76cd412

	RUN tar -xzf mongo-cxx-driver-r3.6.7.tar.gz
	RUN cd mongo-cxx-driver-r3.6.7/build && cmake .. -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/usr/local && sudo cmake --build . --target EP_mnmlstc_core && cmake --build . && sudo cmake --build . --target install

Installation is placed in /usr/local. Therefore, the tar.gz and the directory where the source was unpacked are no longer needed.

It would make for a cleaner Space ROS image to have those removed. I was just now connecting to a Space ROS image via VSCode's file explorer and having that in the folder was unnecessary noise.

I don't want to pollute our issues with too many ideas that we will never do much about, so I'm filing this first here to see what people think. If we like this and plan to act on it, we can promote it to issue.

[Bckempa]

I discussed this with @EzraBrooks last month, the MongoDB components are the vast majority of the build time for the space-robots image right now but are only needed by warehouse. We should verify if this even needs to be in the image first.