Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that EDC_UI_CONFIG_URL allows relative URLs only in deployment guide #1098

Open
SebastianOpriel opened this issue Dec 2, 2024 · 1 comment
Open

Document that EDC_UI_CONFIG_URL allows relative URLs only in deployment guide #1098

SebastianOpriel opened this issue Dec 2, 2024 · 1 comment
Labels
task/documentation Improvements or additions to documentation

Comments

@SebastianOpriel
Copy link
Member

https://github.com/search?q=repo%3Asovity%2Fedc-ce+EDC_UI_CONFIG_URL&type=code It is not explained, that the URL is relative, but in the UI code: https://github.com/sovity/edc-ui/blob/38f2e8a9d9d24806b9731c87edcc6b088b89464b/src/app/core/config/app-config-properties.ts#L24
@SebastianOpriel SebastianOpriel added the task/documentation Improvements or additions to documentation label Dec 2, 2024
@SebastianOpriel SebastianOpriel changed the title Document that EDC_UI_CONFIG_URL allows relative URLs only in deployment guide Document that EDC_UI_CONFIG_URL allows relative URLs only in deployment guide Dec 2, 2024
@tmberthold
Copy link
Contributor

Can't it be both or where is this request coming from? -> If this URL is relative

Absolute -> use it:
https://github.com/sovity/edc-ui/blob/38f2e8a9d9d24806b9731c87edcc6b088b89464b/src/app/core/config/app-config.fetcher.ts#L63

Relative -> append it to Management-API:
https://github.com/sovity/edc-ui/blob/38f2e8a9d9d24806b9731c87edcc6b088b89464b/src/app/core/config/app-config.fetcher.ts#L68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SebastianOpriel @tmberthold