Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Movie page UI optimization #269

Closed
sourabhsikarwar opened this issue Jun 20, 2023 · 11 comments · Fixed by #458 · May be fixed by #336
Closed

Movie page UI optimization #269

sourabhsikarwar opened this issue Jun 20, 2023 · 11 comments · Fixed by #458 · May be fixed by #336
Assignees
Labels
enhancement New feature or request gssoc23 level2

Comments

@sourabhsikarwar
Copy link
Owner

No description provided.

@anamika7153
Copy link
Contributor

What do you want for the UI Enhancemeant @sourabhsikarwar

@anamika7153
Copy link
Contributor

anamika7153 commented Jun 25, 2023

@sourabhsikarwar I have made some changes and I want you to review them before I create a PR.
I have added an overlay also to make the content look clear. Previously the background image was bright enough to mix the content with it.
I am providing some screenshots below. Mobile view looks okay to me so I haven't made any changes to that.

Do let me know if you approve these changes for laptop and tablet screens.
Is there anything else you have in mind for this?


Before After
Large screen
image image
:-----------------: :------------------:
Medium Screen
image image

@sourabhsikarwar
Copy link
Owner Author

The center align content might not look good on the big screens. Its good for mobile view but for laptops it can be left aligned @anamika7153

@sourabhsikarwar
Copy link
Owner Author

Also share mobile view images also

@anamika7153
Copy link
Contributor

Also share mobile view images also

@sourabhsikarwar

image

@anamika7153
Copy link
Contributor

The center align content might not look good on the big screens. Its good for mobile view but for laptops it can be left aligned @anamika7153

Okay, so I will make the content left aligned.

@anamika7153
Copy link
Contributor

@sourabhsikarwar Shall I go ahead and make a PR?

@sourabhsikarwar
Copy link
Owner Author

the paragraph is left aligned, it should be in center for mobile screen and left aligned only for the bigger screens
@anamika7153

@anamika7153
Copy link
Contributor

the paragraph is left aligned, it should be in center for mobile screen and left aligned only for the bigger screens @anamika7153

okay

@anamika7153
Copy link
Contributor

The center align content might not look good on the big screens. Its good for mobile view but for laptops it can be left aligned @anamika7153

@sourabhsikarwar
image

@anamika7153
Copy link
Contributor

@sourabhsikarwar Shall I go ahead and make a PR?

@sourabhsikarwar Is there anything else ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc23 level2
Projects
None yet
2 participants