From e0000947e0a0bb5271f124ea9a1eb6977a8e8a7b Mon Sep 17 00:00:00 2001 From: Simon Lo Date: Fri, 15 Dec 2023 09:22:20 +0000 Subject: [PATCH] Apply suggestions from code review Co-authored-by: jonathan-r-thorpe <64410119+jonathan-r-thorpe@users.noreply.github.com> --- Development/nmos-cpp-node/main.cpp | 4 ++-- Development/nmos/settings.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Development/nmos-cpp-node/main.cpp b/Development/nmos-cpp-node/main.cpp index 2391f9f21..2f1c791d3 100644 --- a/Development/nmos-cpp-node/main.cpp +++ b/Development/nmos-cpp-node/main.cpp @@ -115,7 +115,7 @@ int main(int argc, char* argv[]) } #endif -// only implement communication with Authorization server if IS-10 is required +// only implement communication with Authorization server if IS-10/BCP-003-02 is required // cf. preprocessor conditions in nmos::make_node_api, nmos::make_connection_api, nmos::make_events_api, nmos::make_channelmapping_api, make_events_ws_validate_handler nmos::experimental::authorization_state authorization_state; if (nmos::experimental::fields::server_authorization(node_model.settings)) @@ -153,7 +153,7 @@ int main(int argc, char* argv[]) } #endif -// only implement communication with Authorization server if IS-10 is required +// only implement communication with Authorization server if IS-10/BCP-003-02 is required if (nmos::experimental::fields::client_authorization(node_model.settings)) { std::map api_routers; diff --git a/Development/nmos/settings.h b/Development/nmos/settings.h index e69644e19..3f329c095 100644 --- a/Development/nmos/settings.h +++ b/Development/nmos/settings.h @@ -410,7 +410,7 @@ namespace nmos // authorization_flow [node]: used to specify the authorization flow for the registered scopes // supported flow are authorization_code and client_credentials - // client_credentials SHOULD only be used for NO user interface node/registry, otherwise authorization_code MUST be used + // client_credentials SHOULD only be used when the node/registry has NO user interface, otherwise authorization_code MUST be used const web::json::field_as_string_or authorization_flow{ U("authorization_flow"), U("authorization_code") }; // authorization_redirect_port [node]: redirect URL port for listening authorization code, used for client registration