how is repo used in expect_secure()?

[JosiahParry]

@csgillespie, I'm currently trying to extend the testthat compatibility / functionality and am working off of your existing function. One thing that is not clear is the utility of the repo argument. Other than setting the repo option manually, I cannot figure out what it is used for. Based on my reading it is an unused argument. Can you clairfy?

oysteR/R/expect_secure.R

Line 23 in 0a77663

repo = "https://cran.rstudio.com",

[csgillespie]

Yep this does seem like an odd argument. I think I came across an edge case where {testthat} stripped out the repos

oysteR/R/expect_secure.R

Line 25 in 0a77663

## Need to set the repo, as testthat seems to strip this out?

[JosiahParry]

Interesting. Perhaps it's my naiveté wrt {testthat}. Does testthat require that option be specified? Within audit_description() I don't think any function requires a repo to be specified. Safe to say I can continue developing omitting this arg unless any issue arises?

[csgillespie]

On Thu, 31 Dec 2020, 17:00 Josiah Parry, ***@***.***> wrote: Interesting. Perhaps it's my naiveté wrt {testthat}. Does testthat require that option be specified? Within audit_description() I don't think any function requires a repo to be specified.

The check package function calculates the dependency tree of packages. So not just those in the description file. This requires a repo to be specified Safe to say I can continue developing omitting this arg unless any issue

arises?

It should be obvious if it breaks. My thinking is that sometimes you would specify a specific repo, eg if you are using a tagged rspm. I should probably document this😁 —

…

You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#49 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJVQI3CYZIQLLF6G66YVALSXSU35ANCNFSM4VPSBH2Q> .