Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the character ':' a path separator for id ? #95

Open
cgeoffroy opened this issue Jun 8, 2016 · 1 comment
Open

Is the character ':' a path separator for id ? #95

cgeoffroy opened this issue Jun 8, 2016 · 1 comment
Labels

Comments

@cgeoffroy
Copy link
Contributor

cgeoffroy commented Jun 8, 2016

The current examples make an heavy usage of the ':' character in id and ..._ref fields. But the character : can have multiple meanings, for example in the iperf NSD:

        connection_points:
          - connection_point_ref: "ns:input"
            position: 1
          - connection_point_ref: "vnf_iperf:input"
            position: 2

First "ns:input" refers to the element of id ns:input in the current file. So in this case : don't have any signification.
Whereas "vnf_iperf:input" refers to: an element of id input contained in an external file (a VNFD in this case) fetch-able by the vnf_vendor,vnf_name,vnf_version tuple located under the element of vnd_id = vnf_iperf in the current file.

Is my interpretation totally ludicrous or is it voluntary to have multiple way to interpret the connectio_point-ref field ?. It renders the programmability on descriptor a little more complex.

I would propose to ban the : character from any id or name fields so they only appear in the ..._ref fields as a separator. But it may be too risky with the upcoming demo.

@mbredel
Copy link
Contributor

mbredel commented Jun 16, 2016

Yep, seems like you found a glitch here .... We have to fix it in the future. In addition to the name of the reference point ID, we have to provide a reference to the descriptor file that contains the ID. For example:

        connection_points:
          - connection_point_ref: "ns:input"
            position: 1
          - connection_point_ref: "vnf_iperf:input"
            vnf_ref: "vnf_iperf"
            position: 2

Thus, the first item (that does not contain a vnf_ref field) refers to the local NSD, whereas the second item, refers to the "vnf_iperf" VNF that is identified in the network_functions section.

@mbredel mbredel added the bug label Jun 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants