-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sprockets 4 compatibility #3374
Labels
type:bug
Error, flaw or fault
Comments
spaghetticode
added a commit
to nebulab/solidus
that referenced
this issue
Oct 11, 2019
Temporary fix for solidusio#3374
4 tasks
4 tasks
Fixed by #3379 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Sprockets 4 requires a configuration manifest file to be created in the application. This is fine for new stores but it's not working with our DummyApp at the moment since it is an in-memory application, and not a real application on the filesystem, like most engines do in
spec/dummy
withrake test_app
.At the moment, Sprockets 4 is not able to allow setting a custom location for this configuration manifest file and it is looking for our manifest in
spec/dummy/app/assets/config/manifest.js
, which does not exist. Spec fails consequently.I'm trying to propose a change to sprockets-rails that allows setting a custom location for the manifest with this PR, even because there's a Rails config named
config.assets.manifest
, which I think is only used for this reason, but I'm not super sure since I can't find a lot of documentation around.The only alternative solution I can think about is locking Sprockets to 3.x on all the currently supported Solidus versions.
The text was updated successfully, but these errors were encountered: